Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #3241 #3253

Closed

Conversation

Harshit-7373
Copy link

Icon Alignment Issue in Password Field – Adjust Eye Icon Vertical Centering #3241

github-7373

Fixes #issue-number

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Icon Alignment Issue in Password Field – Adjust Eye Icon Vertical Centering processing#3241

github-7373
Copy link

welcome bot commented Oct 22, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Nov 1, 2024

Thanks for giving this a look!

There's a few issues going on with this pull request, but I feel like one larger one here is that it includes a CSS file rather than a SASS one, which is predominantly used throughout the repository. This causes the branch to not load, which for me, indicates that you weren't able to verify the submitted changes. We strongly encourage ensuring that your changes work, pass all the criteria listed in the checkboxes, and provide a working example (such as screenshots or videos) so your pull request is ready to go once you've submitted it.

I'm going to close this for now, but would encourage you to try to give this another try! If you decide to give this another look, I also feel like that adding an another style sheet probably won't be needed here, as this portion is already being handled in _forms.scss, so that would be a good starting point!

@raclim raclim closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants