Update SignupForm.jsx #3256
Closed
Update SignupForm.jsx #3256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a debouncing logic so as to handle multiple requests
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
lindapaiste
reviewed
Oct 29, 2024
| return asyncValidate('username', username); | ||
| } | ||
| clearTimeout(timeout) | ||
| let timeout= setTimeout(function(){ |
There was a problem hiding this comment.
You don't want a let here because that will create a separate timeout variable that is scoped to within the body of the validateUsername function, rather than re-using the one that you declared outside the function body.
|
Thanks so much for your work on this! Since it's been a while since there were any changes here, I'm going to close this for now, but please feel free to reopen a new PR if you would like to revisit this with any updates, or check out our other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a debouncing logic so as to handle multiple requests
Fixes #3256
Changes:Created a debouncing logic
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123