Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolved the repeated code issue between two files #3259

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

harshit10541
Copy link

Fixes #2805

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Nov 1, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Nov 13, 2024

Thanks for taking a look at this! I think there were a few tasks and questions in the associated issue that would be ideal for folks to address before making changes to the code! Would you be able to add your thoughts or answers to some of them in the description to help get a sense of your changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated code between server previewGeneration.js and client EmbedFrame.jsx
2 participants