Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add margin-left to sort button in sketches page #3436

Merged
merged 3 commits into from
Apr 10, 2025

Conversation

jeanetteandrews
Copy link
Contributor

@jeanetteandrews jeanetteandrews commented Apr 6, 2025

Fixes #3432

Changes:
Added margin-left: #{math.div(5, $base-font-size)}rem; to .sketch-list__sort-button svg in _sketch-list.scss for better spacing of the sort button on the 'Sketches' page.

sort-button


This ensures consistency with the existing code in _nav.scss, where the same margin is applied to .nav__item-header-triangle on the 'Editor' page.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Apr 6, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for much for fixing this @jeanetteandrews, this looks great to me!

@raclim raclim merged commit 8bf9cb4 into processing:develop Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styling bug: Spacing of sorting arrows on sketches and collections page
2 participants