Create Asset List View and refactor overlay code

[catarak]

This is a fix for issue #169. This creates a view for all of a user's assets on S3, and refactors the overlay component code a bit. Some open questions I have:

• Right now a user's assets are being stored on S3 in a folder that is their user id. Would it make sense to also store it in a folder that is the project id, i.e. <user_id>/<project_id>/<asset_name>? There's some discussion about this on Add view for all of a user's S3 files #169. I say this because matching assets to their respective projects is a little slow, but maybe that is just fine.
• The overlay code is better but I think there's some redundancy in the redux state. I think we need one variable that contains whether or not an overlay is visible, and another variable (probably an enum, which in JS can just be a string) that is the contents of the overlay. This can probably be a separate PR.
• Should users be able to delete assets from this view? This brings up the question, if a user deletes an asset from this view, does the asset get deleted from the sketch too? Would it instead make sense to restrict deletion to within a sketch only?

[andrewn]

It might be nice to show a short message when the user has no assets and when the asset list is being fetched? Maybe it's quick enough not to be an issue but initially I was looking at the Overlay wondering if I should be seeing anything.

[catarak]

I agree that it's slow and it may be nice to have a loading state for this view, which could also be used for the SketchList view as well.

Also agree that this should handle the case in which there are no assets 😸

[andrewn]

This button is rendered in the DOM but I can't see it in the UI. It's also not clickable.

[andrewn]

👍 I think having different files would be good as I struggled a bit figuring out where new action constants should go.

[catarak]

Yeah this file has gotten crazy, and can definitely be broken apart. Not sure if it would be better to put this in a folder called "constants" or maybe follow the "ducks" redux design pattern.

[andrewn]

This looks really good! I made some small inline comments.

Overlay

I think the Overlay refactoring is great and cleans things up a lot. I agree about having an Overlay Enum. If it's set then we can display the enum.

Uploading same asset multiple times

I uploaded the same pic.jpg multiple times to the same sketch and it appeared 3 times in the project file browser. However, it is only listed once in the Asset List. I checked the S3 Developer Console and there are 3 assets listed there.

Asset listing being slow / storing by project

I say this because matching assets to their respective projects is a little slow, but maybe that is just fine.

Would this actually speed up the displaying of the list as we'd still need to fetch all the projects and assets to be displayed? This feels like something we could do later? I think that having some sort of loading spinner UI whilst the client is waiting for the data from the API might make it seem snappier?

Deleting assets from Asset List view

My expectation would be that if I delete an asset from this view then it would disappear from the project view too. It might be enough to allow the Asset List columns to be sortable so that users can find what they're looking for and then go straight to the project to manage the assets for that project?

[catarak]

I purposefully hid the delete icon as I wasn't sure if it made sense to add the ability to delete an asset here, but I think it doesn't make sense so I'll remove it.

I'm not sure why the image you uploaded multiple times isn't appearing. That seems like a bug 😈