Enables URL parsing of p5.js version and add-on libraries #3715
+170
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helper functions will ensure URL parameters are normalized before being used.
I have added a test file for the URL parameter parsing utility located at client/utils/parseURLParams.js. This test file includes various test cases to ensure the correct functionality of the parseURLParams function, covering edge cases and typical usage scenarios. For the add-on flags I allowed 'on', 'true', '1', 'ON', 'True', and 'TRUE' to be interpreted as true, while 'off', 'false', '0', 'OFF', 'False', and 'FALSE' are interpreted as false. This should enhance the robustness of the URL parameter parsing in our application.
Convert defaultHTML from a constant string to a function that accepts an options object for version and add-on library configuration. This enables URL parameter parsing for library selection. Maintains backward compatibility - calling defaultHTML() with no arguments produces the same output as before.
Add validation functions to ensure URL parameters for p5.js versioning is correctly parsed and handled. Falls back to default functionality for invalid/missing parameters. Use npx prettier --write to format all modified files. Change test fallbacks to be consistent with default behavior. Add URL parser to client/modules/IDE/reducers/file.js Co-authored-by: Oscar Bedolla <GoodKimchi@users.noreply.github.com> Co-authored-by: Enoch Owoade <enochowoade@gmail.com>
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3647
Changes:
(Potential future extensions)
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123