Skip to content

Fixes #508 #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 15, 2018
Merged

Fixes #508 #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
c255885
removed submodule and replaced interceptor for library
Jan 31, 2018
96f514d
deleted comments
Feb 7, 2018
0f96a7c
deleted jquery
Feb 7, 2018
751b41a
deleted interceptor folder
Feb 7, 2018
703c570
delete interceptor
Feb 7, 2018
a9c0a5c
added jquery
Feb 7, 2018
1a14009
removed jquery and updated accessible library cdn
Feb 12, 2018
1cbe302
remove empty divs from files.js
Feb 15, 2018
9af00e8
fix merge error
Feb 15, 2018
2069eb1
Merge pull request #2 from processing/accessibility
Feb 15, 2018
1bdb417
remove empty divs from files.js
Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions client/modules/IDE/components/PreviewFrame.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,22 +204,27 @@ class PreviewFrame extends React.Component {
];
const accessiblelib = sketchDoc.createElement('script');
accessiblelib.setAttribute('src', 'https://cdn.rawgit.com/MathuraMG/p5-accessibility/9cb5bd0b/dist/p5-accessibility.js');
const accessibleOutputs = sketchDoc.createElement('section');
accessibleOutputs.setAttribute('id', 'accessible-outputs');
if (this.props.textOutput) {
sketchDoc.getElementById('accessibility-library').appendChild(accessiblelib);
sketchDoc.body.appendChild(accessibleOutputs);
sketchDoc.body.appendChild(accessiblelib);
const textSection = sketchDoc.createElement('section');
textSection.setAttribute('id', 'textOutput-content');
sketchDoc.getElementById('accessible-outputs').appendChild(textSection);
this.iframeElement.focus();
}
if (this.props.gridOutput) {
sketchDoc.getElementById('accessibility-library').appendChild(accessiblelib);
sketchDoc.body.appendChild(accessibleOutputs);
sketchDoc.body.appendChild(accessiblelib);
const gridSection = sketchDoc.createElement('section');
gridSection.setAttribute('id', 'gridOutput-content');
sketchDoc.getElementById('accessible-outputs').appendChild(gridSection);
this.iframeElement.focus();
}
if (this.props.soundOutput) {
sketchDoc.getElementById('accessibility-library').appendChild(accessiblelib);
sketchDoc.body.appendChild(accessibleOutputs);
sketchDoc.body.appendChild(accessiblelib);
const soundSection = sketchDoc.createElement('section');
soundSection.setAttribute('id', 'soundOutput-content');
sketchDoc.getElementById('accessible-outputs').appendChild(soundSection);
Expand Down
2 changes: 0 additions & 2 deletions client/modules/IDE/reducers/files.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ const defaultHTML =

</head>
<body>
<section aria-label='accessible output' id='accessible-outputs'></section>
<script src="sketch.js"></script>
<div id='accessibility-library'></div>
</body>
</html>
`;
Expand Down