Skip to content

fixes #384 #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2018
Merged

fixes #384 #563

merged 4 commits into from
Feb 27, 2018

Conversation

himanshuc3
Copy link
Contributor

  • Correct Font size
  • Correct positioning to bottom

@himanshuc3
fixes #384
2db4716 
Positioning and font-size was off.
catarak
catarak requested changes Feb 21, 2018
View reviewed changes
client/styles/components/_toast.scss Outdated
@@ -3,8 +3,10 @@
color: $toast-text-color;
padding: #{10 / $base-font-size}rem;
position: absolute;
top: 0;
right: 40%;
bottom: 5vh;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use consistent measurements here? for the site i've been using rems, which are easy to convert with SCSS:
#{<pixels> / $base-font-size}rem;

@catarak
Copy link
Member

catarak commented Feb 22, 2018

a few things:

  1. I think the toast needs to be a little higher on the page (and a little more to the right). Could you use percentage instead of vh?
  2. It needs a minimum width (in the mockups it's 500px).
  3. Instead of centering the text with line-height, could you use flexbox? IMO this is more semantically correct.

Thank you!

catarak
catarak requested changes Feb 26, 2018
View reviewed changes
client/styles/components/_toast.scss Outdated
left: 5%;
min-width: #{375 / $base-font-size}rem; //500px
font-size: #{20 / $base-font-size}rem;
line-height: #{24 / $base-font-size}rem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need line height here 😄

@catarak catarak merged commit ea02d76 into processing:master Feb 27, 2018
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catarak catarak catarak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshuc3 @catarak