Skip to content

Serve text-type assets from sketch asset urls - Fixes #839 #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 22, 2019

Conversation

meiamsome
Copy link
Member

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

Potentially will also resolve some other issues (See the discussion in #839) I haven't verified those use cases work though, so will refrain from tagging them with the 'fixes' keyword

@catarak
Copy link
Member

catarak commented Feb 22, 2019

cool! this is working for me. i tested this with files with a url and those are working as well. going to merge this!

@catarak catarak merged commit 03d7533 into processing:master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants