Skip to content

[WIP] Remove file menu on blur #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

nimishagarwal76
Copy link
Contributor

@nimishagarwal76 nimishagarwal76 commented Mar 9, 2019

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e. Fixes #874

Fixes #874

This PR resolves the issue of multiple file menu as on blurring, they will be hidden.
But this work in all cases except when we right click on the current file as it automatically changes the focus to the ˅ resulting in losing of focus from the file name and disappearing of menu. If you right click on the ˅. @catarak why is a down arrow required specifically for the current file, whereas it is not availaible for other files.

@nimishagarwal76 nimishagarwal76 changed the title Remove file menu on blur [WIP] Remove file menu on blur Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple file options
1 participant