Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bezier curve reference is wrong in Spanish version #1411

Closed
sbsacev opened this issue Aug 14, 2023 · 6 comments · Fixed by #1443
Closed

Bezier curve reference is wrong in Spanish version #1411

sbsacev opened this issue Aug 14, 2023 · 6 comments · Fixed by #1443

Comments

@sbsacev
Copy link

sbsacev commented Aug 14, 2023

Language

Spanish

What improvement are you suggesting?

The reference of bezier curve ([https://p5js.org/es/reference/#/p5/bezier]) is wrong, it says (p5.js-website/src/data/reference
/es.json), lines 525 to 536:
"x1": "Número: coordenada x del primer punto ancla",
"y1": "Número: coordenada y del primer punto ancla",
"x2": "Número: coordenada y del primer punto de control",
"y2": "Número: coordenada x del segundo punto de control",
"x3": "Número: coordenada x del segundo punto ancla",
"y3": "Número: coordenada y del segundo punto ancla",
"x4": "Número: coordenada z del primer punto de control",
"y4": "Número: coordenada z del segundo punto ancla",
"z1": "Número: coordenada x del primer punto de control",
"z2": "Número: coordenada y del segundo punto de control",
"z3": "Número: coordenada z del primer punto ancla",
"z4": "Número: coordenada z del segundo punto de control"

And must say:
"x1": "Número: coordenada x del primer punto ancla",
"y1": "Número: coordenada y del primer punto ancla",
"x2": "Número: coordenada x del primer punto de control",
"y2": "Número: coordenada y del primer punto de control",
"x3": "Número: coordenada x del segundo punto de control",
"y3": "Número: coordenada y del segundo punto de control",
"x4": "Número: coordenada x del segundo punto ancla",
"y4": "Número: coordenada y del segundo punto ancla",
"z1": "Número: coordenada z del primer punto ancla",
"z2": "Número: coordenada z del primer punto de control",
"z3": "Número: coordenada z del segundo punto de control",
"z4": "Número: coordenada z del segundo punto ancla"

Would you like to work on the issue?

Yes, I can work on it.

@Qianqianye
Copy link
Contributor

Thank you @sbsacev!

I'm tagging a few Spanish translation stewards to review the proposed change:@Guirdo, @Andreu-G, @dnd-alv, @holomorfo. Does the suggested translation look right to you? Thanks!

@raphaelavelar
Copy link
Contributor

@Qianqianye, I'm actually the Portuguese translation steward, but, if I may add, the proposed change does not affect the translation per se. The problem is that the x and y are in the wrong places. For example:
Original
"x2": "Número: coordenada y del primer punto de control",
"y2": "Número: coordenada x del segundo punto de control",
"x4": "Número: coordenada z del primer punto de control",
"y4": "Número: coordenada z del segundo punto ancla",
"z1": "Número: coordenada x del primer punto de control",
"z2": "Número: coordenada y del segundo punto de control",

Since this hasn't been worked on for a while, may I take it?

@limzykenneth
Copy link
Member

@raphaelavelar You can go ahead with a fix. Thanks.

@Marcelito444
Copy link

Just wanted to note that the error is still there.

@raphaelavelar
Copy link
Contributor

Yeah, sorry about that. I got caught up with other things.
I'll create a PR by tomorrow

@raphaelavelar
Copy link
Contributor

Sorry for taking so long. I've just created the PR and saw some things that were wrong in the reference when comparing to the English version.
I didn't change the words, just updated the values to refer to the original version.

limzykenneth added a commit that referenced this issue Nov 16, 2023
…reference

Fixes #1411: Bezier reference for the Spanish translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants