Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed-link #1421

Conversation

umangutkarsh
Copy link
Contributor

Fixes #1375

Changes:
I replaced the broken link, by removing it.

Screenshots of the change:
p5

@limzykenneth
Copy link
Member

Hi @umangutkarsh, I'm afraid simply removing it will not work. The original sentence is

There is a working spreadsheet here that outlines in progress tutorials.

and if we remove it as per this PR it will become

There is that outlines in progress tutorials.

which doesn't really make sense as a sentence.

@harshsharma-11
Copy link

@limzykenneth i think ,it will be better to remove anchor tag from the link, but not removing the text remain it as plain text

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Oct 5, 2023

Hi @umangutkarsh, I'm afraid simply removing it will not work. The original sentence is

There is a working spreadsheet here that outlines in progress tutorials.

and if we remove it as per this PR it will become

There is that outlines in progress tutorials.

which doesn't really make sense as a sentence.

I agree, but then we'll need a link to redirect the user to the spreadsheet.
link
But instead it redirects the user to^ as per Issue: #1375

Or should we change the sentence. What do you say?

@limzykenneth
Copy link
Member

@harshsharma-11 Simply removing the link and not changing the text will also not make sense since it is referring to something that doesn't exist (ie. "There is a working spreadsheet here" but "here" points to nowhere).

@umangutkarsh As mentioned in the original issue, the suggestion is to change/rephrase the section so that it does not refer to the spreadsheet.

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Oct 6, 2023

@harshsharma-11 Simply removing the link and not changing the text will also not make sense since it is referring to something that doesn't exist (ie. "There is a working spreadsheet here" but "here" points to nowhere).

@umangutkarsh As mentioned in the original issue, the suggestion is to change/rephrase the section so that it does not refer to the spreadsheet.

Hi @limzykenneth , I've rephrased the text in the .yml files of the listed languages. Please review the PR if anything else is required.
Thanks

@umangutkarsh
Copy link
Contributor Author

@harshsharma-11 Simply removing the link and not changing the text will also not make sense since it is referring to something that doesn't exist (ie. "There is a working spreadsheet here" but "here" points to nowhere).
@umangutkarsh As mentioned in the original issue, the suggestion is to change/rephrase the section so that it does not refer to the spreadsheet.

Hi @limzykenneth , I've rephrased the text in the .yml files of the listed languages. Please review the PR if anything else is required. Thanks

Hi @limzykenneth, can you please review it? Thanks

@limzykenneth
Copy link
Member

The two sentences are more or less saying the same thing so it feels like repeating now. Would you like some suggestions on possible rephrasing?

@umangutkarsh
Copy link
Contributor Author

The two sentences are more or less saying the same thing so it feels like repeating now. Would you like some suggestions on possible rephrasing?

Yeah sure.

@umangutkarsh
Copy link
Contributor Author

umangutkarsh commented Oct 20, 2023

The two sentences are more or less saying the same thing so it feels like repeating now. Would you like some suggestions on possible rephrasing?

Hi @limzykenneth, I added ->
Ensure your chosen topic has not been previously covered. Review the available resources. If your topic is already in progress, consider contributing to the existing work and helping prepare it for publication. Feel free to reach out to us for guidance. If your topic hasn't been covered and isn't currently in progress, please provide a brief description of your proposed topic. You can send this description to us at education@p5js.org.

This is for the english language. It cannot redirect to the existing resources, since there is no spreadsheet. Would be helpful if you suggest some phrases.
Please consider this, Thanks.

Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to the translation files (es.yml, hi.yml, it.yml, ko.yml, and zh-Hans.yml) as they are just formatting changes but will have a unintended effects on the rendering of those pages.

src/data/en.yml Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
src/templates/pages/learn/tutorial-guide.hbs Outdated Show resolved Hide resolved
@umangutkarsh
Copy link
Contributor Author

@limzykenneth. I've made the changes, please review it. Thanks for your time.

@umangutkarsh
Copy link
Contributor Author

Please revert changes to the translation files (es.yml, hi.yml, it.yml, ko.yml, and zh-Hans.yml) as they are just formatting changes but will have a unintended effects on the rendering of those pages.

@limzykenneth do I have to make any other changes to the PR? If yes, please let me know. Thanks.

@limzykenneth
Copy link
Member

Merged with d9c8283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in tutorial-guide.html
3 participants