Resolves #831: Reduces calls to Open Processing API to prevent hitting rate limit errors #838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue:
#831
Changes:
getCuratedSketchesgetSketch(id)to first check in the memoizedgetCuratedSketchesresults for an item with matchingvisualIDfirst, then only calls OpenProcessing API for the individual sketch Id if no memoized item is foundgetSketchon the SketchLayout -- I thought this increased legibility, but happy to take this outNotes:
I took a look at removing the call to
/api/codewhich is ingetSketchSize/codeis used just to get thewidthandheightproperties of a sketchwidthandheightto the data for bothgetCuratedSketchesandgetSketch(id), I'll make a followup PR to refactor and eliminate the extra API call to/api/codeas well!