The p5 library is missing

[hellonearthis]

Hi there!

I was looking at download p5 to use locally and I can't seem to find it.

I started with looking to download 1.0.0 from cloudflare but it's serving the wrong version.

So I looked in the https://github.com/processing/p5.js/tree/main/lib expecting it to be there.

But no. So I downloaded the p5 repo and searched for p5*js and p5.js and it's not there too

I did manage to download it from https://github.com/processing/p5.js/releases/

Which seemed kind of hidden to me and I don't if it's a bug/broken
or something else (user problem: me :) )

[jeremydouglass]

I think "the library is missing" is just not right. It is right there in releases.

https://github.com/processing/p5.js/releases/tag/1.0.0

You can see that file drop commit here -- maybe it was a mistake, but maybe not, and the readme should just be updated.

bf0e9aa#diff-eccec67c712f3fdf3dfe1c0a5397edde

After all, most software is built and released, not checked in to its own repo.

That said, the cloudflare bug seems like a big deal. I'd either retitle your issue about that or open a separate issue about "Cloudflare 1.0 loads 0.10.2" -- because that is a clear problem.

[jeremydouglass]

It looks to me like this is the offending commit to cloudflare -- although I'm not familiar with their infrastructure.

https://github.com/cdnjs/cdnjs/tree/master/ajax/libs/p5.js/1.0.0

So a couple months ago a bot checked in the p5.js 0.10.2 files to their CDN repo on the /1.0.0 path.

Where does cloudflare get the files? Not this repo's releases, I guess, unless they grabbed a bad release in February that has since been changed. Do they get it from someplace that this project configures / controls? @lmccart

[lmccart]

I think this happened due to an error in the build process when we posted 1.0.0. The best way to resolve it would be to make a patch or minor release.

[jeremydouglass]

Quick follow-up If the minor release is to 1.0.1 and it gets picked up, won't that mean that the CDN caches a bad version of 1.0.0 forever?

[lmccart]

yes, I don't know if there's a way to fix the CDN, it reads from npmjs which can't be edited. maybe submitting a manual pull request?

[jeremydouglass]

maybe submitting a manual pull request?

Sure -- are the canonical artifacts that I should put in that PR currently in this repo's 1.0.0 release download?

[lmccart]

I'm sorry I'm not quite sure what "canonical artifacts" are, but the correct library files are posted here: https://github.com/processing/p5.js/releases/tag/1.0.0

[jeremydouglass]

I meant, if I post the stuff from the release, is it the right stuff, or is it also bad stuff.

[jeremydouglass]

Great -- I'll try to make a PR as soon as I can, later today at earliest. If anyone else wants to first, go ahead. Looks like the cdnjs repo is over 10GB70GB on disk -- time for a shallow clone, but most PRs seem to go through fast.

[lmccart]

ah got it, the right stuff :)
thank you!

[jeremydouglass]

What a headache. Finally got a commit made against cdnjs, and in the diff it looks like the version number strings are the only difference. Anyhow, I'll ping you on the PR -- they really want authors/core developers signing off on requests.

[jeremydouglass]

Great -- sign off on issue / PR here:

cdnjs/cdnjs#13912
cdnjs/cdnjs#13913

[lmccart]

wow, I didn't realize it was only the version number that got screwed up. well, thank you for looking into it and submitting the fix!