Skip to content

decouple param validation from ellipse and rect drawing #4174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2019
Merged

decouple param validation from ellipse and rect drawing #4174

merged 4 commits into from
Dec 2, 2019

Conversation

outofambit
Copy link
Contributor

@outofambit outofambit commented Dec 2, 2019 •
edited
Loading

resolves #4051

Changes

  • moved the call to the renderer for ellipse into a separate function so ellipse and circle could both call it directly with their own parameter validation
  • same for rect and square

PR Checklist

  • npm run lint passes

@outofambit outofambit changed the title decouple param validation from ellipse drawing decouple param validation from ellipse and rect drawing Dec 2, 2019
@outofambit outofambit merged commit aec19e0 into processing:master Dec 2, 2019
@outofambit outofambit deleted the bugfix/circle-fes-msg branch December 2, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Friendly Errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrapper function error messages refer to their core function name
1 participant
@outofambit