Align the method of moving the camera with the right button in orbitControl() to the movement of the mouse #6116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far the right mouse button translates the camera only parallel to the XZ plane, so let's rewrite it to cover the distance traveled along the mouse movement. This allows you to achieve the same behavior regardless of scale.
We will prepare a new function to obtain the result of applying it to a vector when a square matrix of order 4 is regarded as a matrix in the shader. This is because some of these are used in the camera translation method when doing orbitControl().
Minor fixes for indentation, extra spaces and character counts
davepagurek
approved these changes
Apr 23, 2023
|
Thanks for merge! ('ω') It was my first time adding a method, but it was fun! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6107
Changes:
Currently, the orbitControl() method for moving the camera with the right mouse button only allows movement parallel to the XZ plane.
However, in software such as blender, parallel movement of the camera is implemented by movement within the plane perpendicular to the line of sight. So I wanted to do it that way.
This moves the center position of the appearance according to the movement of the mouse. Intuitive operation is possible by shifting the viewpoint in the opposite direction to the operation direction, like a map application.
It's also true that the movement distance depends on the actual value of the mouse movement distance, so it has a similar problem to mouse scrolling, where it moves too much at small scales. In order to solve this problem, I thought it would be natural to move the mouse along with the movement of the mouse.
Screenshots of the change:
sample code: improve panning Demo
2023-04-23.03-03-26.mp4
PR Checklist
npm run lintpasses