Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fes zh trans #6210

Merged
merged 1 commit into from
Jun 24, 2023
Merged

add fes zh trans #6210

merged 1 commit into from
Jun 24, 2023

Conversation

asukaminato0721
Copy link
Contributor

Relevant: #4233

Changes:

Screenshots of the change:

PR Checklist

@Qianqianye
Copy link
Contributor

Thanks @wuyudi for working on it. I know @@Ayush23Dash is planning to work on i18n for FES messages during GSoC, so I am inviting GSoC FES contributor @Ayush23Dash and mentors @almchung @nbriz to review the PR.

@Ayush23Dash
Copy link
Contributor

Thanks for adding this translation @wuyudi!
The PR looks good, I checked the translations, the use of original inline variables while translating is something noteworthy!
It is good to be approved and merged from my side @Qianqianye

@limzykenneth limzykenneth merged commit 644b096 into processing:main Jun 24, 2023
@limzykenneth
Copy link
Member

Looks good. Thanks!

@asukaminato0721 asukaminato0721 deleted the fes-zh-trans branch July 19, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asukaminato0721 @Qianqianye @Ayush23Dash @limzykenneth