Skip to content

Fix: keyTyped() can now accept the same char consecutively #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Fix: keyTyped() can now accept the same char consecutively #7808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/events/keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,11 +441,13 @@ p5.prototype.keyCode = 0;
* </div>
*/
p5.prototype._onkeydown = function(e) {
// Ignore repeated key events when holding down a key
if (e.repeat) {
// Ignore repeated key events when holding down a key
this._setProperty('isKeyRepeated', true);
return;
}

this._setProperty('isKeyRepeated', false);
this._setProperty('isKeyPressed', true);
this._setProperty('keyIsPressed', true);
this._setProperty('keyCode', e.which);
Expand Down Expand Up @@ -781,7 +783,7 @@ p5.prototype._onkeyup = function(e) {
* </div>
*/
p5.prototype._onkeypress = function(e) {
if (e.which === this._lastKeyCodeTyped) {
if (e.which === this._lastKeyCodeTyped && this.isKeyRepeated) {
// prevent multiple firings
return;
}
Expand Down