Only create FilterRenderer2D lazily #8181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8180
Changes:
renderer.filterRendererinto a getter that lazily constructs the renderer if it does not yet existThis allows the creation of many more 2D graphics than was available in 2.x previously, matching what 1.x could do. It's true that if you were to run a filter on all of them, then you'd still hit the same issue, but that issue was also present in 1.x.
Live test of the fix: https://editor.p5js.org/davepagurek/sketches/dnQ0jgkvU
PR Checklist
npm run lintpasses