-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fixes in dev-2.0 #8272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes in dev-2.0 #8272
Conversation
|
@perminder-17 please review this Pr |
perminder-17
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I don't understand the reason to add these tests. Currently out unit tests doesn't pass, you need to fix them as I mentioned on the previous comment. I also mentioned the way to make the tests pass. Please consider that.
|
In addition to addressing @perminder-17 's comments, please ensure that your PRs clearly link to the related issue (with "Resolves ___" or "Fixes ___"). Thank you! |
|
hi @perminder-17 still the test cases fails please help me !! |
Hi @perminder-17 please see locally all the test pases but why it show error here at pull request please tell
|
|
Hi! The workflow failure seems intermittent. Could you please re-run the CI for this PR? |
|
Hi @ayushman1210 , thank you for your effort here. However, this PR touches many unrelated files, including images and workflows. To make tests pass it's important to improve the specific fix you're working on; in this case, making many other changes (even if tests do end up passing) is not the answer. The purpose of tests is to make sure fixes are isolated and have no side effects. I'll close this PR and reassign the issue. In the future, please make sure your PRs are clearly linked, that you take feedback into account, and that there are no unrelated changes in the PR. This makes it really difficult to help guide the issue. For more guidance on future issues, Discord might also be a better place to ask for help. Thanks for your understanding. |

What was fixed: