Skip to content

Added fancy pde:// install button #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Added fancy pde:// install button #27

wants to merge 13 commits into from

Conversation

SableRaf
Copy link
Contributor

Added an install button point at the .pdex file using the custom pde:// uri protocol.

The button includes a tooltip with fallback instructions.

image

Context

Processing 4.2 added the new pde:// protocol which allows you to open Processing sketches and contributions in the PDE directly from the browser. It builds up on the previous addition of bundled sketches and contributions with the .pdez and .pdex formats.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for android-processing-d1396c ready!

Name Link
🔨 Latest commit 1abada0
🔍 Latest deploy log https://app.netlify.com/sites/android-processing-d1396c/deploys/6697d727f34bdd00086bd96c
😎 Deploy Preview https://deploy-preview-27--android-processing-d1396c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SableRaf
Copy link
Contributor Author

SableRaf commented Jul 16, 2024

Hmmm... Looks like the changes I made are causing Processing to see the source as untrusted. This didn't happen with a simple link as it is currently set up on the production deploy. Nevermind it's also broken today. Pretty sure it worked when I tried it yesterday.

cc @mingness @Stefterv

image

@Stefterv
Copy link
Collaborator

@SableRaf
Copy link
Contributor Author

SableRaf commented Jul 16, 2024

Oh my bad! You're right. This is a necessary warning. I just got confused by the scheme8019... title which really obfuscates the question mark. I wonder where that string comes from 🤔 It should be the name of the contribution.

Edit: Getting closer...

String baseName = contribFile.getName();
baseName = baseName.substring(0, baseName.length() - CONTRIB_BUNDLE_EXT.length());

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these side-wide changes be part of a different PR? It hides what you actually did

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it! I'm splitting this PR into several more specific ones.

@SableRaf
Copy link
Contributor Author

Closing and splitting this PR into three: #30 #29 #28

@SableRaf SableRaf closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants