-
Notifications
You must be signed in to change notification settings - Fork 8
Added fancy pde:// install button #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for android-processing-d1396c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hmmm... Looks like the changes I made are causing Processing to see the source as untrusted. ![]() |
Looking at the source code it will always show that dialog: https://github.com/benfry/processing4/blob/6a2cf8cda35552c62a1a794bb1e20f43fe8ffcda/app/src/processing/app/Base.java#L1245 |
Oh my bad! You're right. This is a necessary warning. I just got confused by the Edit: Getting closer... String baseName = contribFile.getName();
baseName = baseName.substring(0, baseName.length() - CONTRIB_BUNDLE_EXT.length()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these side-wide changes be part of a different PR? It hides what you actually did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On it! I'm splitting this PR into several more specific ones.
Added an install button point at the
.pdex
file using the custompde://
uri protocol.The button includes a tooltip with fallback instructions.
Context
Processing 4.2 added the new
pde://
protocol which allows you to open Processing sketches and contributions in the PDE directly from the browser. It builds up on the previous addition of bundled sketches and contributions with the.pdez
and.pdex
formats.