maven to maven-publish #635
Conversation
|
@rupesh-kumar-lpu thanks a lot for this PR! I will review and merge into the next release of the mode. |
|
@codeanticode thanks for your valuable response! Changes are there in three 'build.gradle' files (Core, AR, and VR). Some of the commits are changed again and again making the PR a bit unordered to review. You may review the code directly from the forked maven-publish branch, related to this PR. If there is a need I can create a separate squash and merge PR. Thanks! |
mode/libraries/ar/build.gradle
Outdated
| dependencyNode.appendNode('scope', 'implementation') | ||
|
|
||
| def dependencyNode2 = dependenciesNode.appendNode('dependency') | ||
| dependencyNode2.appendNode('groupId', 'com.google.ar') |
There was a problem hiding this comment.
Use proper names for the variables !
PS: as mentioned above about the naming of variables.
There was a problem hiding this comment.
Corrected variable names in AR build.gradle
core/build.gradle
Outdated
| dependencyNode.appendNode('version', "${v4legacyVersion}") | ||
| dependencyNode.appendNode('scope', 'implementation') | ||
|
|
||
| def dependencyNode2 = dependenciesNode.appendNode('dependency') |
There was a problem hiding this comment.
I think you should follow proper naming of variables !
ex - instead of dependencyNode you can use something like androidLegacyDependancyNode
and instead of dependencyNode2 you can use wearableDependencyNode
Proper naming of variables is very important in any OpenSource project !
There was a problem hiding this comment.
Corrected variable names in Core build.gradle file, Thanks for providing a clear example!
mode/libraries/vr/build.gradle
Outdated
| dependencyNode2.appendNode('version', "${gvrVersion}") | ||
| dependencyNode2.appendNode('scope', 'implementation') | ||
|
|
||
| def dependencyNode3 = dependenciesNode.appendNode('dependency') |
There was a problem hiding this comment.
Please rename variables here as well !
There was a problem hiding this comment.
Corrected variables in VR build.gradle file.
|
@ranaaditya The changes have been done. I'll keep in mind using relevant variable names as you suggested, thanks for correcting! |
Fixes #623
Maven plugin is completely removed and replaced by the new maven-publish plugin. Creates pom files in respected dist folders. The pom files are copied from build/publications/pub-name/pom-default.xml to the dist directory.
Usage
Creation of pom-default.xml files at locations:
root/core/build/publications/corePublication/pom-default.xml
root/mode/libraries/ar/build/publications/arPublication/pom-default.xml
root/mode/libraries/vr/build/publications/vrPublication/pom-default.xml
Commands to generate these files are:
gradle generatePomFileForcorePublicationPublication
gradle generatePomFileForarPublicationPublication
gradle generatePomFileForvrPublicationPublication
Before executing Gradle build, Either the above commands need to be executed one by one or combined as:
The error will be handled with the instructions in case if 'gradle build' is executed before the creation of pom files as follows: