Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error highlighting placement / width incorrect. #714

Closed
processing-bot opened this issue May 10, 2023 · 7 comments
Closed

Syntax error highlighting placement / width incorrect. #714

processing-bot opened this issue May 10, 2023 · 7 comments

Comments

@processing-bot
Copy link
Collaborator

Created by: sampottinger

Description

Trying back to 4.1, error highlighting doesn't appear to be working (at least on Linux).

Expected Behavior

Expected a red underline at line 4 or 5.

Current Behavior

No line shown

Steps to Reproduce

Use the code provided and wait for error checking:

void setup() {
  size(100, 100)
  background(#FFFFFF);
}

void draw() {
}

Your Environment

  • Processing version: 4.2
  • Operating System and OS version: Pop!_OS 22.04 LTS
  • Other information: x64

Possible Causes / Solutions

I'll check if this is linux specific... possible there's something in theming or attribution.

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

Here it is on Linux...

v42

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

Looks like this is happening on my mac too...

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

However, it does work as expected on the 4.0.x releases it appears...

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

I'll try to see what happened here and get back soon. It looks like it might be a thing about placement / width but the errors are still correctly placed when running a full compile.

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

It looks like this came about potentially in conjunction with the language server implementation where the offset isn't being passed into the issue.

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

Looks like this came up in ac062a5 when editor was not longer present for building Problems

@processing-bot
Copy link
Collaborator Author

Created by: sampottinger

I know we don't have an imminent release but this is is getting in the way of a GSoC project. To make sure he can still finish on time / pass, I'm going to merge this to main but I won't make a release. Without this sorted, the error message rewriting isn't visible to the user.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant