Skip to content

Add warning for default pixelDensity behavior #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2025
Merged

Add warning for default pixelDensity behavior #1226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
906ab17
Add warning for default pixelDensity behavior
Stefterv Sep 4, 2025
3814307
Update the warning message for pixelDensity
SableRaf Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions core/src/processing/core/PApplet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,6 +802,7 @@ public PSurface getSurface() {
// Unlike the others above, needs to be public to support
// the pixelWidth and pixelHeight fields.
public int pixelDensity = 1;
boolean pixelDensityWarning = false;

boolean present;

Expand Down Expand Up @@ -1082,6 +1083,9 @@ public int displayDensity(int display) {
*/
public void pixelDensity(int density) {
//println(density + " " + this.pixelDensity);


this.pixelDensityWarning = false;
if (density != this.pixelDensity) {
if (insideSettings("pixelDensity", density)) {
if (density != 1 && density != 2) {
Expand Down Expand Up @@ -2050,6 +2054,10 @@ public void handleDraw() {
if (frameCount == 0) {
setup();

if(pixelDensityWarning){
System.err.println("Warning: Processing now sets pixelDensity(2) by default on high-density screens. This may change how your sketch looks. To revert to the old behavior, set pixelDensity(1) in setup().");
}

} else { // frameCount > 0, meaning an actual draw()
// update the current frameRate

Expand Down Expand Up @@ -10106,6 +10114,7 @@ static public void runSketch(final String[] args,
sketch.fullScreen = fullScreen;

sketch.pixelDensity = sketch.displayDensity();
sketch.pixelDensityWarning = sketch.pixelDensity > 1;

// For 3.0.1, moved this above handleSettings() so that loadImage() can be
// used inside settings(). Sets a terrible precedent, but the alternative
Expand Down
Loading