Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support XEP-0357: Push Notifications #1881

Merged
merged 2 commits into from
Aug 4, 2017
Merged

Support XEP-0357: Push Notifications #1881

merged 2 commits into from
Aug 4, 2017

Conversation

weiss
Copy link
Member

@weiss weiss commented Jul 21, 2017

This adds two modules (and a few helper functions to other modules):

  • mod_push implements (the XMPP server part of) XEP-0357: Push Notifications, with the business rules suggested by Daniel Gultsch.
  • mod_push_keepalive tries to keep the XEP-0198 session alive for disconnected (but reachable) push clients, mostly to make push notifications work for standard MUC rooms. The idea is to not let the session expire unless the client failed to resume it after a push notification. (Large servers might want to disable this to save resources.)

SQL/Riak support is still missing.

weiss added 2 commits July 20, 2017 20:22
This module tries to keep pending stream management sessions of push
clients alive (as long as the disconnected clients are reachable via
push notifications).
@zinid
Copy link
Contributor

zinid commented Jul 21, 2017

Finally :)

@cwildfoerster
Copy link

Whats missing for merging?

@cromain cromain added this to the ejabberd 17.08 milestone Aug 2, 2017
@cromain cromain mentioned this pull request Aug 2, 2017
@cromain
Copy link
Contributor

cromain commented Aug 3, 2017

@weiss just ping me when you think it's ready for merge. you may add other backends later after 17.08.

@weiss
Copy link
Member Author

weiss commented Aug 4, 2017

Yes, I think this can be merged.

@cromain cromain merged commit 766b7c6 into processone:master Aug 4, 2017
@weiss weiss deleted the push branch August 6, 2017 22:52
@erdii
Copy link

erdii commented May 7, 2018

where can i find the documentation for using mod_push with ejabberd?

@weiss
Copy link
Member Author

weiss commented May 7, 2018

where can i find the documentation for using mod_push with ejabberd?

You can simply enable mod_push without options as in the sample configuration. Adding some documentation is on my to-do list.

@erdii
Copy link

erdii commented May 15, 2018

Thank you!

@manthan29
Copy link

We have been struggling to activate push notifications. Can anyone point me to the documentation as to how can I enable push notification with FCM the server. Also what do we need to do from the client application.

@weiss
Copy link
Member Author

weiss commented Jun 4, 2018

See #2109 (comment)

@gylraj
Copy link

gylraj commented Aug 31, 2018

does it support Voip push?

@zinid
Copy link
Contributor

zinid commented Aug 31, 2018

@gylraj no, whatever that means.

@licaon-kter
Copy link
Contributor

@gylraj ejabberd sends a push request, it depends on your app and push server to register with Apple as a VoIP app to be able to get a VoIP push, else it will get a standard push.

@fingertips-solutions
Copy link

fingertips-solutions commented Feb 4, 2019

any documentation for this how can we use it with apple p8 certificates ? @weiss @gylraj

@licaon-kter
Copy link
Contributor

@fingertips-solutions this concerns ejabberd how? What push server do you use for your app?

@fingertips-solutions
Copy link

fingertips-solutions commented Feb 4, 2019 via email

@weiss
Copy link
Member Author

weiss commented Feb 12, 2019

@fingertips-solutions, from the docs:

This module implements the XMPP server's part of the push notification solution specified in XEP-0357. It does not generate, for example, APNS or FCM notifications directly. Instead, it's designed to work with so-called "app servers" operated by third-party vendors of mobile apps.

@lock
Copy link

lock bot commented Feb 12, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants