Skip to content
This repository was archived by the owner on Jan 21, 2019. It is now read-only.

Conversation

mremond
Copy link
Member

@mremond mremond commented Oct 16, 2015

No description provided.

@mremond mremond added this to the 1.1.1 milestone Oct 16, 2015
@zinid
Copy link
Contributor

zinid commented Oct 16, 2015

I guess make spec in ejabberd will fail because xml_gen.beam is not in ebin directory anymore.

@mremond
Copy link
Member Author

mremond commented Oct 16, 2015

Why should it be in ebin ?

Makefile is doing:

        erlc -o tools -I include tools/xml_gen.erl
        erl -noinput +B -pa tools -eval 'case xml_gen:compile("tools/xmlrpc_codec.spec") of ok -> halt(0); _ -> halt(1) end.' 

Erlang path is pointing to tools.

@zinid
Copy link
Contributor

zinid commented Oct 16, 2015

Because ejabberd doesn't see 'tools' directory of p1_xml, only 'ebin': https://github.com/processone/ejabberd/blob/master/Makefile.in#L109

@mremond
Copy link
Member Author

mremond commented Oct 16, 2015

ejabberd is not involved in my test. I only do:

  1. clone p1_xml and configure
  2. call make xmlrpc-codec, as I have added make target to generate that .erl file.

That the

@mremond
Copy link
Member Author

mremond commented Oct 16, 2015

As commented by Evgeny: ejabberd rebuilds xmpp spec on each build and needs xml_gen.beam for that. Theorically, it should be more a new rebar plugin or mix compiler.

@mremond mremond removed this from the 1.1.1 milestone Oct 16, 2015
mathiasertl pushed a commit to jabber-at/xml that referenced this pull request Mar 26, 2017
build: add FreeBSD NIF build code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants