Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProcessPageExportImport.module needs wireCount on line 810 #1572

Closed
adrianbj opened this issue May 21, 2022 · 3 comments
Closed

ProcessPageExportImport.module needs wireCount on line 810 #1572

adrianbj opened this issue May 21, 2022 · 3 comments

Comments

@adrianbj
Copy link

Short description of the issue

https://github.com/processwire/processwire/blob/3acd7709c1cfc1817579db00c2f608235bdfb1e7/wire/modules/Process/ProcessPagesExportImport/ProcessPagesExportImport.module#L810

Expected behavior

It works without error

Actual behavior

It throws the [count(): Argument #1 ($var) must be of type Countable|array] error

@BernhardBaumrock
Copy link

@adrianbj is this related? processwire/processwire#225

@adrianbj
Copy link
Author

@BernhardBaumrock - it's the same error. I actually just found another one in Profields Table as well.

Remember that these errors were really prevalent when PHP 7.2 was first released. Ryan fixed most of them with the new wireCount() function, but there are obviously some still lingering.

ryancramerdesign added a commit to processwire/processwire that referenced this issue May 27, 2022
@ryancramerdesign
Copy link
Member

Thanks @adrianbj I've fixed that line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants