FieldtypePage: Selectability of unpublished pages depends on chosen input field class

[rwetzlmayr]

Steps to reproduce with a recent devns clone:

1. Add a field of type 'Page' to a template.
2. Configure its input field type to 'Select Multiple'
   
3. Uncheck 'Allow unpublished pages?'
4. Unpublish one of the eligible pages, e.g. 'Child page example 1' from the stock basic site profile.
5. Create a page using this template and find that 'Child page example 1' is not an available option
   
6. Configure the 'Page' field's input field to one of 'PageListSelect', 'PageListSelectMultiple', 'PageAutocomplete'.
7. Create a page using this template and find that 'Child page example 1' is an available option
   
   

I think this confuses users as the unpublished pages, while selectable, are not persisted when 'Allow unpublished pages?' is unchecked.

(This issue is a resurface attempt for ryancramerdesign/ProcessWire#1973, as suggested in #1)

[isellsoap]

I tried to reproduce your issue with the latest ProcessWire version (3.0.34) from the new repository, and I had to stop at step #5, because the unpublished page appears in the page field:

Please specify your exact ProcessWire version ("recent devns clone" isn’t very specific). Can you try it also with the newest ProcessWire version and confirm my observation? If you can, please upgrade to the latest ProcessWire version. In the meantime, I will label this issue "not reproducible".

[rwetzlmayr]

I can reproduce this issue's step 5 w/ PW 3.0.34 from the new repo while I cannot confirm your observation.

I believe that the code building the selector which excludes unpublished pages from the InputfieldSelectMultiple element is here.

I think that this code path is executed when the Page field is configured to not Allow unpublished pages? and has a Template of selectable page(s) set, and thus the situation in step 5 should be reproducible.

Would you mind re-checking whether your PW instance uses the Page field with these two settings in effect?

[isellsoap]

Sorry, I didn’t fully comprehend the issue you were having. You are right, I can reproduce the issue.

The end result is correct (after saving the page the selected page, which shouldn’t be selectable, isn’t persisted), but I agree that from a user perspective it is a bit confusing that it is still possible to select the page in the first place.

[ryancramerdesign]

This feature was added awhile back at Teppo's request (if I recall), and it's something that FieldtypePage supports, but not all page selection Inputfield types. I may be able to have the autocomplete one just omit unpublished pages for this case, but if not then certainly a strikethrough on the label (or something like that) would be worthwhile. We can't omit unpublished from the page tree just because a parent may be unpublished while the children might not be. Because support really depends on the Inputfield type (whether or 3rd party), I'll solve this issue by having it issue a save warning that unpublished pages aren't allowed to be stored in the selection. I'm also thinking in some cases we may be able to automatically append "(unpublished)" label to the selected label for additional clarity.

[ryancramerdesign]

I've pushed a fix for this issue. For PageListSelect types it provides a warning when the page is saved. For Autocomplete, I was able to have it suppress showing of unpublished pages.