Skip to content

SystemUpdaterChecks.php checkSystemTimes() #2148

@BrendonKoz

Description

@BrendonKoz

This should be an easy one. This is the first time I've had this issue, but because my production server's database is physically hosted on different hardware than my webserver, the reported PHP and MySQL time check was off. That being said, I've already fixed the timezone issue in config; it was off by 4 seconds. I was still told to update my config timezone.

Image

Because I can't actually fix this with a config change, I propose the following:

Proposed fix at line 474:
Instead of:
if($diff < 3) return true;
Set to:
if($diff < 15 * 60) return true;

15 minutes is currently the smallest incremental change of time for timezone differences.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions