Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling of expanded hidden parent incorrect in page tree list. #6

Closed
adrianbj opened this issue Sep 26, 2016 · 3 comments
Closed

Styling of expanded hidden parent incorrect in page tree list. #6

adrianbj opened this issue Sep 26, 2016 · 3 comments

Comments

@adrianbj
Copy link

Briefly describe the issue.

When you expand a branch in the page tree which has a parent which is "hidden", it is no longer lighter colored text once it has been clicked and its children are shown

What did you expect to happen?

I think it should have the yellow highlighter background, but still be the lighter color text

What did actually happen?

Text is dark, just like a normal, not hidden page

Optional: Do you have screenshots/links that demonstrate the issue?

screen shot 2016-09-26 at 2 42 58 pm
screen shot 2016-09-26 at 2 43 06 pm

This can actually be quite annoying when you have a lot of expanded branches because you have to mouseover to check whether the action button shows Hide or Unhide to know its status.

@adrianbj
Copy link
Author

PS - to honest I wasn't really sure if this should be in the Issues repo or the Requests repo. I do think it's a bug, but not that critical.

Pity there is no easy way to move or tag.

@isellsoap
Copy link
Collaborator

If I see this correctly it would be just a matter of removing :not(.PageListItemOpen) from this line.

ryancramerdesign added a commit to processwire/processwire that referenced this issue Oct 4, 2016
…n pages in PageList no longer showing hidden state
@ryancramerdesign
Copy link
Member

I've pushed an update that corrects this. Also thanks for identifying the solution @isellsoap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants