Skip to content

Wrong order of a fieldset opening and closing in template makes pages not saving any more #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tbba opened this issue Sep 28, 2016 · 4 comments

Comments

@tbba
Copy link

tbba commented Sep 28, 2016

Briefly describe the issue.

Page does not save content, but still sends a green "saved" response, if the template has a wrong order of fieldset and fieldset_END. That was one of my recent mystery bugs only in combination with a certain template. Somehow I must have inadvertently dragged the wrong field and ended with a wrong order.

What did you expect to happen?

Wrong order of a fieldset opening and closing field is not allowed or there is a warning.
Or a correction like we have it when a missing _END field is added.

What did actually happen?

I could save the template with my error in it. No warning, no automated fix.
The corresponding page opened as normal on editing but any changes to the content were not saved. The failure was silent, no errors, notices or anything.

Optional: Have you a suggestion for a possible fix?

I corrected the order of the fieldset after I discovered the issue and now PW behaves normal.
I cannot blame PW for it as it was the result of a mistake from my part but maybe that effect is interesting to know for you.

Tell us about the setup you experienced the bug in.

  • ProcessWire version: 3.034 - live and localhost, on 2 different installs.
  • (Optional) PHP version: 7-10
@isellsoap
Copy link
Collaborator

isellsoap commented Sep 30, 2016

I can reproduce the issue on a fresh 3.0.34 installation.

@tbba
Copy link
Author

tbba commented Sep 30, 2016

Thank you for your feedback :-)

ryancramerdesign added a commit to processwire/processwire that referenced this issue Oct 4, 2016
…hown if user mismatches fieldset order in ProcessTemplate
@ryancramerdesign
Copy link
Member

I've pushed an update so that it shows an error message if you get the order wrong with your fieldset open/close fields.

@tbba
Copy link
Author

tbba commented Oct 4, 2016

Great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants