Allow needle argument to 'in' expression to be false (mapbox#9295)

procore · Mar 18, 2020 · 2e5a895 · 2e5a895
1 parent 348b948
commit 2e5a895
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/style-spec/expression/definitions/in.js b/src/style-spec/expression/definitions/in.js
@@ -62,7 +62,7 @@ class In implements Expression {
         const needle = (this.needle.evaluate(ctx): any);
         const haystack = (this.haystack.evaluate(ctx): any);
 
-        if (!needle || !haystack) return false;
+        if (needle == null || !haystack) return false;
 
         if (!isComparableRuntimeValue(needle)) {
             throw new RuntimeError(`Expected first argument to be of type boolean, string or number, but found ${toString(typeOf(needle))} instead.`);

diff --git a/test/integration/expression-tests/in/basic-string/test.json b/test/integration/expression-tests/in/basic-string/test.json
@@ -24,7 +24,7 @@
       false,
       true,
       true,
-      false,
+      true,
       true,
       false
     ],
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,7 +24,7 @@ @@
           false,
           true,
           true,
-          false,
+          true,
           true,
           false
         ],
@@ Expand Down @@