Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify job context #1213

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Simplify job context #1213

merged 1 commit into from
Oct 12, 2024

Conversation

onlyann
Copy link
Contributor

@onlyann onlyann commented Oct 6, 2024

Closes #1212

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

Remove from JobContext job_result, task_result and task to keep them internal to the worker.

@onlyann onlyann requested a review from a team as a code owner October 6, 2024 06:40
@github-actions github-actions bot added the PR type: breaking 💥 Contains breaking changes label Oct 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  procrastinate
  job_context.py
  worker.py
Project Total  

This report was generated by python-coverage-comment-action

@onlyann onlyann force-pushed the leaner-job-context branch from a3b50e3 to 35a31e2 Compare October 6, 2024 06:48
ewjoachim
ewjoachim approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
(one more thing to remember when we'll prepare the release notes)

@ewjoachim ewjoachim merged commit a8c7fc3 into procrastinate-org:v3 Oct 12, 2024
11 checks passed
@medihack medihack mentioned this pull request Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
PR type: breaking 💥 Contains breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@onlyann @ewjoachim