Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate stanza-id warning for every message. #1925

Closed
mdosch opened this issue Nov 11, 2023 · 0 comments · Fixed by #1926
Closed

Duplicate stanza-id warning for every message. #1925

mdosch opened this issue Nov 11, 2023 · 0 comments · Fixed by #1926

Comments

@mdosch
Copy link
Contributor

mdosch commented Nov 11, 2023

With profanity commit bba8278 I get the warning Got a message with duplicate (server-generated) stanza-id from [REDACTED] for every 1-1 message I received:

grep 9dd00770-38b1-4f5a-894c-1e03e708be99 ~/.local/share/profanity/logs/profanity.log
2023-11-11T12:29:44.852453+01: xmpp: DBG: RECV: <message to="martin@mdosch.de/profanity.rocks" type="chat" from="martin@mdosch.de"><sent xmlns="urn:xmpp:carbons:2"><forwarded xmlns="urn:xmpp:forward:0"><message id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="jabber:client" lang="en" type="chat" from="martin@mdosch.de/Conversations~83Z9+FM/xdas"><body>I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo</body><encrypted xmlns="eu.siacs.conversations.axolotl"><header sid="167497379"><key rid="579850519">MwohBQZH8ChkB2d5ditTnFDo2fVPkwaq2ZcPcApe9DOV4JU6ENQIGAgiMAJWWsJnKUb77fIxaMtctqC6sKegamBVi7MPvBQR/3BBJfM4N4CPbaYMeM2UOhgwyAaycNyIYw5p</key><key rid="416045743">MwohBYLkBzKRPTRGU+32zXjliD3Cu0INVENalNzhLA5j4epbEOwJGAAiMIVchZ5houPhot/0bDjR1cFFQZO9YyfxvS2yZZnsqwoo7aJjs6Xex3noySYUDSsu5Gwl0CB6ZLyv</key><key rid="1462613928">MwohBZJZUmBgNAt18YnBEIFfbEvkuG+nBBkAHJM4J9B2ZnIiELgDGJgRIjCNYwYWJ3rShykf3BfhUnFFl5sOcg1qCJ9vW8BpojJt57BTZn3ieHbkoNXZzywG7zE1leY0K+1OaA==</key><key rid="1032437584">MwohBXd8he8OH8BUucDMMIIwKtrDcbdqYGv2bXBSwnh+HShoEJMBGAEiMJRRBJV2gua8wqxMc4uCVnHPhqXNhcC2dZ5MgIFkWTzzlWnNuuY6K1NHF5flAN4BSzZXibbTdgQY</key><key rid="294991371">MwohBTgULh1utAZ6ONx0Oh4DwGBU8XZpRflJSioq9nuFiiFuEAAYESIwCxeDOKWjMUvLydCUFinZHx8LpOLNGxOxo2JdzPlEwSGfe6fwy+M9p72FGeYTa7WwZ+DW3QB6QzE=</key><iv>Y/s+Ym5i55K5uZV7</iv></header><payload>i/aPXA==</payload></encrypted><markable xmlns="urn:xmpp:chat-markers:0"/><origin-id id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="urn:xmpp:sid:0"/><store xmlns="urn:xmpp:hints"/><encryption namespace="eu.siacs.conversations.axolotl" xmlns="urn:xmpp:eme:0" name="OMEMO"/><stanza-id id="2023-11-11-4eb8362daf2897a8" by="martin@mdosch.de" xmlns="urn:xmpp:sid:0"/></message></forwarded></sent></message>
2023-11-11T12:29:44.970370+01: prof: DBG: Writing to DB. Query: INSERT INTO `ChatLogs` (`from_jid`, `from_resource`, `to_jid`, `to_resource`, `message`, `timestamp`, `stanza_id`, `archive_id`, `replaces_db_id`, `replace_id`, `type`, `encryption`) VALUES ('martin@mdosch.de', 'Conversations~83Z9+FM/xdas', 'martin@mdosch.de', 'Conversations~83Z9+FM/xdas', 'Test', '2023-11-11T12:29:44.852757+01', '9dd00770-38b1-4f5a-894c-1e03e708be99', '2023-11-11-4eb8362daf2897a8', NULL, NULL, 'chat', 'omemo')
2023-11-11T12:29:44.980274+01: xmpp: DBG: RECV: <message id="9dd00770-38b1-4f5a-894c-1e03e708be99" lang="en" to="martin@mdosch.de" type="chat" from="martin@mdosch.de/Conversations~83Z9+FM/xdas"><body>I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo</body><encrypted xmlns="eu.siacs.conversations.axolotl"><header sid="167497379"><key rid="579850519">MwohBQZH8ChkB2d5ditTnFDo2fVPkwaq2ZcPcApe9DOV4JU6ENQIGAgiMAJWWsJnKUb77fIxaMtctqC6sKegamBVi7MPvBQR/3BBJfM4N4CPbaYMeM2UOhgwyAaycNyIYw5p</key><key rid="416045743">MwohBYLkBzKRPTRGU+32zXjliD3Cu0INVENalNzhLA5j4epbEOwJGAAiMIVchZ5houPhot/0bDjR1cFFQZO9YyfxvS2yZZnsqwoo7aJjs6Xex3noySYUDSsu5Gwl0CB6ZLyv</key><key rid="1462613928">MwohBZJZUmBgNAt18YnBEIFfbEvkuG+nBBkAHJM4J9B2ZnIiELgDGJgRIjCNYwYWJ3rShykf3BfhUnFFl5sOcg1qCJ9vW8BpojJt57BTZn3ieHbkoNXZzywG7zE1leY0K+1OaA==</key><key rid="1032437584">MwohBXd8he8OH8BUucDMMIIwKtrDcbdqYGv2bXBSwnh+HShoEJMBGAEiMJRRBJV2gua8wqxMc4uCVnHPhqXNhcC2dZ5MgIFkWTzzlWnNuuY6K1NHF5flAN4BSzZXibbTdgQY</key><key rid="294991371">MwohBTgULh1utAZ6ONx0Oh4DwGBU8XZpRflJSioq9nuFiiFuEAAYESIwCxeDOKWjMUvLydCUFinZHx8LpOLNGxOxo2JdzPlEwSGfe6fwy+M9p72FGeYTa7WwZ+DW3QB6QzE=</key><iv>Y/s+Ym5i55K5uZV7</iv></header><payload>i/aPXA==</payload></encrypted><markable xmlns="urn:xmpp:chat-markers:0"/><origin-id id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="urn:xmpp:sid:0"/><store xmlns="urn:xmpp:hints"/><encryption namespace="eu.siacs.conversations.axolotl" xmlns="urn:xmpp:eme:0" name="OMEMO"/><stanza-id id="2023-11-11-1761a9cb9f25558c" by="martin@mdosch.de" xmlns="urn:xmpp:sid:0"/></message>
2023-11-11T12:29:45.005809+01: prof: DBG: Writing to DB. Query: INSERT INTO `ChatLogs` (`from_jid`, `from_resource`, `to_jid`, `to_resource`, `message`, `timestamp`, `stanza_id`, `archive_id`, `replaces_db_id`, `replace_id`, `type`, `encryption`) VALUES ('martin@mdosch.de', 'Conversations~83Z9+FM/xdas', 'martin@mdosch.de', NULL, 'I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo', '2023-11-11T12:29:44.980511+01', '9dd00770-38b1-4f5a-894c-1e03e708be99', '2023-11-11-1761a9cb9f25558c', NULL, NULL, 'chat', 'none')
2023-11-11T12:29:45.056892+01: xmpp: DBG: RECV: <message to="martin@mdosch.de/profanity.rocks"><result id="2023-11-11-4eb8362daf2897a8" xmlns="urn:xmpp:mam:2"><forwarded xmlns="urn:xmpp:forward:0"><delay xmlns="urn:xmpp:delay" stamp="2023-11-11T11:29:44.788197Z"/><message id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="jabber:client" lang="en" type="chat" from="martin@mdosch.de/Conversations~83Z9+FM/xdas"><body>I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo</body><encrypted xmlns="eu.siacs.conversations.axolotl"><header sid="167497379"><key rid="579850519">MwohBQZH8ChkB2d5ditTnFDo2fVPkwaq2ZcPcApe9DOV4JU6ENQIGAgiMAJWWsJnKUb77fIxaMtctqC6sKegamBVi7MPvBQR/3BBJfM4N4CPbaYMeM2UOhgwyAaycNyIYw5p</key><key rid="416045743">MwohBYLkBzKRPTRGU+32zXjliD3Cu0INVENalNzhLA5j4epbEOwJGAAiMIVchZ5houPhot/0bDjR1cFFQZO9YyfxvS2yZZnsqwoo7aJjs6Xex3noySYUDSsu5Gwl0CB6ZLyv</key><key rid="1462613928">MwohBZJZUmBgNAt18YnBEIFfbEvkuG+nBBkAHJM4J9B2ZnIiELgDGJgRIjCNYwYWJ3rShykf3BfhUnFFl5sOcg1qCJ9vW8BpojJt57BTZn3ieHbkoNXZzywG7zE1leY0K+1OaA==</key><key rid="1032437584">MwohBXd8he8OH8BUucDMMIIwKtrDcbdqYGv2bXBSwnh+HShoEJMBGAEiMJRRBJV2gua8wqxMc4uCVnHPhqXNhcC2dZ5MgIFkWTzzlWnNuuY6K1NHF5flAN4BSzZXibbTdgQY</key><key rid="294991371">MwohBTgULh1utAZ6ONx0Oh4DwGBU8XZpRflJSioq9nuFiiFuEAAYESIwCxeDOKWjMUvLydCUFinZHx8LpOLNGxOxo2JdzPlEwSGfe6fwy+M9p72FGeYTa7WwZ+DW3QB6QzE=</key><iv>Y/s+Ym5i55K5uZV7</iv></header><payload>i/aPXA==</payload></encrypted><markable xmlns="urn:xmpp:chat-markers:0"/><origin-id id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="urn:xmpp:sid:0"/><store xmlns="urn:xmpp:hints"/><encryption namespace="eu.siacs.conversations.axolotl" xmlns="urn:xmpp:eme:0" name="OMEMO"/></message></forwarded></result></message>
2023-11-11T12:29:45.080548+01: prof: ERR: Duplicate stanza-id found for the message. stanza_id: 9dd00770-38b1-4f5a-894c-1e03e708be99; archive_id: 2023-11-11-4eb8362daf2897a8; sender: martin@mdosch.de; content: I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo
2023-11-11T12:29:45.080814+01: prof: DBG: Writing to DB. Query: INSERT INTO `ChatLogs` (`from_jid`, `from_resource`, `to_jid`, `to_resource`, `message`, `timestamp`, `stanza_id`, `archive_id`, `replaces_db_id`, `replace_id`, `type`, `encryption`) VALUES ('martin@mdosch.de', 'Conversations~83Z9+FM/xdas', 'martin@mdosch.de', 'profanity.rocks', 'I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo', '2023-11-11T12:29:44.788197+01', '9dd00770-38b1-4f5a-894c-1e03e708be99', '2023-11-11-4eb8362daf2897a8', NULL, NULL, 'chat', 'none')
2023-11-11T12:29:45.093329+01: xmpp: DBG: RECV: <message to="martin@mdosch.de/profanity.rocks"><result id="2023-11-11-1761a9cb9f25558c" xmlns="urn:xmpp:mam:2"><forwarded xmlns="urn:xmpp:forward:0"><delay xmlns="urn:xmpp:delay" stamp="2023-11-11T11:29:44.791523Z"/><message id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="jabber:client" lang="en" to="martin@mdosch.de" type="chat" from="martin@mdosch.de/Conversations~83Z9+FM/xdas"><body>I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo</body><encrypted xmlns="eu.siacs.conversations.axolotl"><header sid="167497379"><key rid="579850519">MwohBQZH8ChkB2d5ditTnFDo2fVPkwaq2ZcPcApe9DOV4JU6ENQIGAgiMAJWWsJnKUb77fIxaMtctqC6sKegamBVi7MPvBQR/3BBJfM4N4CPbaYMeM2UOhgwyAaycNyIYw5p</key><key rid="416045743">MwohBYLkBzKRPTRGU+32zXjliD3Cu0INVENalNzhLA5j4epbEOwJGAAiMIVchZ5houPhot/0bDjR1cFFQZO9YyfxvS2yZZnsqwoo7aJjs6Xex3noySYUDSsu5Gwl0CB6ZLyv</key><key rid="1462613928">MwohBZJZUmBgNAt18YnBEIFfbEvkuG+nBBkAHJM4J9B2ZnIiELgDGJgRIjCNYwYWJ3rShykf3BfhUnFFl5sOcg1qCJ9vW8BpojJt57BTZn3ieHbkoNXZzywG7zE1leY0K+1OaA==</key><key rid="1032437584">MwohBXd8he8OH8BUucDMMIIwKtrDcbdqYGv2bXBSwnh+HShoEJMBGAEiMJRRBJV2gua8wqxMc4uCVnHPhqXNhcC2dZ5MgIFkWTzzlWnNuuY6K1NHF5flAN4BSzZXibbTdgQY</key><key rid="294991371">MwohBTgULh1utAZ6ONx0Oh4DwGBU8XZpRflJSioq9nuFiiFuEAAYESIwCxeDOKWjMUvLydCUFinZHx8LpOLNGxOxo2JdzPlEwSGfe6fwy+M9p72FGeYTa7WwZ+DW3QB6QzE=</key><iv>Y/s+Ym5i55K5uZV7</iv></header><payload>i/aPXA==</payload></encrypted><markable xmlns="urn:xmpp:chat-markers:0"/><origin-id id="9dd00770-38b1-4f5a-894c-1e03e708be99" xmlns="urn:xmpp:sid:0"/><store xmlns="urn:xmpp:hints"/><encryption namespace="eu.siacs.conversations.axolotl" xmlns="urn:xmpp:eme:0" name="OMEMO"/></message></forwarded></result></message>
2023-11-11T12:29:45.117702+01: prof: ERR: Duplicate stanza-id found for the message. stanza_id: 9dd00770-38b1-4f5a-894c-1e03e708be99; archive_id: 2023-11-11-1761a9cb9f25558c; sender: martin@mdosch.de; content: I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo
2023-11-11T12:29:45.117978+01: prof: DBG: Writing to DB. Query: INSERT INTO `ChatLogs` (`from_jid`, `from_resource`, `to_jid`, `to_resource`, `message`, `timestamp`, `stanza_id`, `archive_id`, `replaces_db_id`, `replace_id`, `type`, `encryption`) VALUES ('martin@mdosch.de', 'Conversations~83Z9+FM/xdas', 'martin@mdosch.de', NULL, 'I sent you an OMEMO encrypted message but your client doesn’t seem to support that. Find more information on https://conversations.im/omemo', '2023-11-11T12:29:44.791523+01', '9dd00770-38b1-4f5a-894c-1e03e708be99', '2023-11-11-1761a9cb9f25558c', NULL, NULL, 'chat', 'none')
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 11, 2023
@H3rnand3zzz
Fix Duplicate stanza-id errors flood for MAM
44d72e3 
Before profanity checked (server-generated) stanza-id for duplication,
but MAM check was missing,
it caused significant false positive error flood.

Fix profanity-im#1925
@H3rnand3zzz H3rnand3zzz mentioned this issue Nov 11, 2023
Merged
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Nov 13, 2023
@H3rnand3zzz
Do not check for unique stanza-id for MAM messages
d3566b1 
Since we might have MAM messages already received earlier
it doesn't make sense to require unique stanza-ids there.
Fix profanity-im#1925.
H3rnand3zzz added a commit to H3rnand3zzz/profanity that referenced this issue Dec 28, 2023
@H3rnand3zzz
Do not check for unique stanza-id for MAM messages
1a8b9d2 
Since we might have MAM messages already received earlier
it doesn't make sense to require unique stanza-ids there.
Fix profanity-im#1925.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not check for unique stanza-id for MAM messages H3rnand3zzz/profanity
1 participant
@mdosch