Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

[Bug] GitLab 11.11 failure to run glab pipeline status -l #335

Closed
zemzale opened this issue Nov 27, 2020 · 1 comment · Fixed by #336
Closed

[Bug] GitLab 11.11 failure to run glab pipeline status -l #335

zemzale opened this issue Nov 27, 2020 · 1 comment · Fixed by #336
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority: high Affects a large population and inhibits work

Comments

@zemzale
Copy link
Collaborator

zemzale commented Nov 27, 2020

Description
Opening this issue to track it separately from #325 since it's issue with the same command, but is not the same issue.
As per comments #325 (comment) #325 (comment) there is failure to run glab pipeline status -l on GitLab 11.11.
This is because we use order_by:updated_at and it wasn't in the GitLab 11.11 API
Expected Behavior
Should be execute the command and view pipeline status
Actual Behavior
The response is :

GET https://gitlab..../api/v4/projects/tools/templates/pipelines: 400 {error: order_by does not have a valid value}

Possible Fix

We could check the version of the GitLab we are running against, and if it's 11.11 then we just don't pass this order by parameter.
I have not looked into how important is the ordering but if it's needed we can just request these pipelines one by one and order them ourselfs.
Steps to Reproduce

  1. Try to execute glab pipeline status -l on GitLab 11.11

Your Environment

As per #325 (comment)

  • Version used: GitLab 11.11 glab 1.11.1 (note: GitLab 12.10 is mentioned too, but that shouldn't be affected)
@zemzale zemzale added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 27, 2020
@profclems profclems added the priority: high Affects a large population and inhibits work label Nov 28, 2020
@profclems
Copy link
Owner

Maybe we can just take out that part

OrderBy: gitlab.String("updated_at"),

I don't think the ordering is really that important

zemzale added a commit to zemzale/glab that referenced this issue Nov 28, 2020
This field is not supported in GitLab 11.11. This doesn't allow this
command to be run against this version of GitLab.

Since this ordering is not that important easiest is just to remove it.

See: https://docs.gitlab.com/11.11/ee/api/pipelines.html#list-project-pipelines

Fixes profclems#335
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed priority: high Affects a large population and inhibits work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants