Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix: default GIT_REMOTE_URL_VAR to origin if not specified by user #109

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

Baiang
Copy link
Contributor

@Baiang Baiang commented Aug 18, 2020

Reolves #97

@pull-assistant
Copy link

pull-assistant bot commented Aug 18, 2020

Score: 0.46

Best reviewed: with all changes


Optimal code review plan (3 commits squashed)

add:It can specify I... ... fix:styles

Squashed 3 commits:

Powered by Pull Assistant. Last update 9f28a88 ... 4fc2d95. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and make sure your commit message and PR title follows the semantic naming approach
Please make sure to read the contributing guide. You should also provide more details as to why the changes are relevant.
Thanks for contributing...

internal/git/git.go Outdated Show resolved Hide resolved
@Baiang Baiang changed the title add:It can specify Item lookup Feat:It can specify Item lookup Aug 18, 2020
@profclems
Copy link
Owner

profclems commented Aug 20, 2020

@Baiang sorry for the late review... I saw you were pushing commits os I thought it's still in progress.
I have gone through and seen this is a great fix. I'll merge right away
Thanks!

@profclems profclems changed the title Feat:It can specify Item lookup fix: default --remote-var to origin is not specified by user Aug 20, 2020
@profclems profclems changed the title fix: default --remote-var to origin is not specified by user fix: default GIT_REMOTE_URL_VAR to origin if not specified by user Aug 20, 2020
@profclems profclems merged commit bbf17ca into profclems:trunk Aug 20, 2020
@profclems
Copy link
Owner

@all-contributors please add @Baiang for code

@allcontributors
Copy link
Contributor

@profclems

I've put up a pull request to add @Baiang! 🎉

j-mcavoy pushed a commit to j-mcavoy/glab that referenced this pull request Aug 29, 2020
…rofclems#109)

* add:It can specify Item lookup'

* fix:git Description error

* fix:styles

Co-authored-by: weiwei.yang <weiwei.yang@zhangmen.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants