Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat: Add release command #110

Merged
merged 2 commits into from
Aug 19, 2020
Merged

feat: Add release command #110

merged 2 commits into from
Aug 19, 2020

Conversation

pgollangi
Copy link
Contributor

@pgollangi pgollangi commented Aug 18, 2020

  • Define release base command
  • Add release list command

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Define release base command
- Add release list command
@pull-assistant
Copy link

pull-assistant bot commented Aug 18, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     feat: Add release command

     fix: deepsource error report

Powered by Pull Assistant. Last update 54e7e85 ... 27af884. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Do you have plans of adding commands to create a release in your free time??

@pgollangi
Copy link
Contributor Author

pgollangi commented Aug 19, 2020

Haha yes, ofcourse @profclems

@pgollangi pgollangi closed this Aug 19, 2020
@pgollangi pgollangi reopened this Aug 19, 2020
@profclems
Copy link
Owner

Haha yes, ofcourse @profclems

Haha... good work

@profclems
Copy link
Owner

Do you want this PR merged while you work on the others or after you're done?

@pgollangi
Copy link
Contributor Author

@profclems I would like to incrementally complete it. Please merge this PR to avoid rework in case of structural changes happening across all commands. I will raise a separate PR for remaining work.

@profclems profclems merged commit e9544ac into profclems:trunk Aug 19, 2020
@profclems
Copy link
Owner

@all-contributors please add @pgollangi for code

@allcontributors
Copy link
Contributor

@profclems

I've put up a pull request to add @pgollangi! 🎉

Repository owner deleted a comment from allcontributors bot Aug 19, 2020
@pgollangi pgollangi deleted the ft-releases branch August 20, 2020 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants