Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

fix(config): respect api_protocol in config #275

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Conversation

profclems
Copy link
Owner

Fixes #270

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #275 into trunk will increase coverage by 0.09%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #275      +/-   ##
==========================================
+ Coverage   46.05%   46.15%   +0.09%     
==========================================
  Files         113      113              
  Lines        5977     5982       +5     
==========================================
+ Hits         2753     2761       +8     
+ Misses       2924     2922       -2     
+ Partials      300      299       -1     
Impacted Files Coverage Δ
pkg/api/client.go 34.54% <33.33%> (ø)
commands/cmdutils/factory.go 69.23% <80.00%> (+0.48%) ⬆️
cmd/glab/main.go 45.58% <100.00%> (+2.10%) ⬆️
internal/glinstance/host.go 100.00% <100.00%> (ø)
internal/config/config_type.go 81.23% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64faac7...ea17693. Read the comment docs.

@profclems profclems merged commit 74b2d8e into trunk Oct 21, 2020
@profclems profclems deleted the fix-api-protocol branch October 21, 2020 13:01
@profclems profclems added this to the v1.11.0 milestone Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

api_protocol seems to be ignored
1 participant