Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat: Add ability to mark branch to be deleted from update #278

Merged
merged 2 commits into from
Oct 25, 2020

Conversation

zemzale
Copy link
Collaborator

@zemzale zemzale commented Oct 25, 2020

Description
This MR adds option to mark branch to be deleted form update command.

Related Issue

#273
Motivation and Context

We can create MR that are marked to be deleted, but we can't update that. This fixes that.
How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #278 into trunk will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #278      +/-   ##
==========================================
- Coverage   46.15%   46.14%   -0.01%     
==========================================
  Files         113      113              
  Lines        5982     5985       +3     
==========================================
+ Hits         2761     2762       +1     
- Misses       2922     2924       +2     
  Partials      299      299              
Impacted Files Coverage Δ
commands/mr/update/mr_update.go 27.14% <33.33%> (+0.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b2d8e...aa1a889. Read the comment docs.

@profclems profclems changed the title Add ability to mark branch to be deleted from update feat: Add ability to mark branch to be deleted from update Oct 25, 2020
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zemzale! LGTM 🎉

@profclems profclems merged commit 855b18e into profclems:trunk Oct 25, 2020
@profclems profclems added this to the v1.11.0 milestone Oct 25, 2020
@profclems profclems linked an issue Oct 25, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to mark branch to be deleted on merge
2 participants