Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

chore: create glab installer for windows using innosetup #374

Merged
merged 16 commits into from
Dec 17, 2020

Conversation

profclems
Copy link
Owner

@profclems profclems commented Dec 15, 2020

Description

Related Issue

#103

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #374 (2342749) into trunk (a3fda2e) will increase coverage by 6.23%.
The diff coverage is 61.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #374      +/-   ##
==========================================
+ Coverage   46.62%   52.86%   +6.23%     
==========================================
  Files         116       71      -45     
  Lines        6224     4519    -1705     
==========================================
- Hits         2902     2389     -513     
+ Misses       2998     1896    -1102     
+ Partials      324      234      -90     
Impacted Files Coverage Δ
commands/alias/expand/alias_expand.go 39.21% <0.00%> (ø)
commands/auth/login/login.go 46.45% <0.00%> (+8.38%) ⬆️
commands/cmdutils/cmdutils.go 0.00% <0.00%> (ø)
commands/cmdutils/factory.go 0.00% <0.00%> (-69.24%) ⬇️
commands/config/config.go 37.93% <0.00%> (-23.81%) ⬇️
commands/pipeline/ci/view/pipeline_ci_view.go 48.00% <0.00%> (-5.20%) ⬇️
commands/project/archive/repo_archive.go 0.00% <0.00%> (-26.03%) ⬇️
commands/project/create/project_create.go 0.00% <0.00%> (-11.28%) ⬇️
internal/config/config.go 0.00% <0.00%> (ø)
internal/git/git.go 32.75% <0.00%> (-16.38%) ⬇️
... and 83 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47a414e...2342749. Read the comment docs.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 15, 2020
@profclems profclems marked this pull request as draft December 16, 2020 04:26
@profclems profclems marked this pull request as ready for review December 17, 2020 03:00
@profclems profclems merged commit 5fbb2fa into trunk Dec 17, 2020
@profclems profclems deleted the chore-win-packaging branch December 17, 2020 03:00
profclems added a commit that referenced this pull request Dec 17, 2020
`glab` can now be installed via winget, the official Microsoft package manager.
I submitted a PR with manifest for glab microsoft/winget-pkgs#5561.

This PR add documentation on how to install `glab` via winget.

Follow up to #374 
Resolves #103
profclems added a commit that referenced this pull request Dec 17, 2020
`glab` can now be installed via winget, the official Microsoft Package manager.
I submitted a PR with a manifest for `glab` to be added to winget packages microsoft/winget-pkgs#5561 which has been approved and merged.

This PR adds documentation on how to install with winget.
Follow up PR to #374 
Resolves #103
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant