`issue create` and `mr create` escape #430

maxice8 · 2020-12-28T09:02:10Z

Description

See description of the git commits

Related Issue

Resolves #429

How Has This Been Tested?

Tested description handling but not label handling yet

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation
Chore (Related to CI or Packaging to platforms)

maxice8 · 2020-12-28T09:02:34Z

We might also need to do it for mr create where applicable

profclems · 2020-12-28T09:36:47Z

We might also need to do it for mr create where applicable

Yeah mr create will also need that

maxice8 · 2020-12-28T09:37:29Z

It is also done

commands/mr/create/mr_create.go

commands/issue/create/issue_create.go

This is required for complex enough labels like `type:build-failure`, if there are no double quotes around it, GitLab will fail to parse it.

…Query It is required, otherwise long descriptions will complex lines like build logs will fail

This is required for complex enough labels like `type:build-failure`, if there are no double quotes around it, GitLab will fail to parse it.

It is required, otherwise long descriptions will complex lines like build logs will fail

pull-request-size bot added the size/XS label Dec 28, 2020

profclems changed the title ~~Glab issue create escape~~ issue create and mr create escape Dec 28, 2020

profclems added cmd: issue Related to issues management cmd: mr Issue is related to merge request management Fix This fixes a bug or incorrect documentation labels Dec 28, 2020

profclems reviewed Dec 28, 2020

View reviewed changes

commands/mr/create/mr_create.go Outdated Show resolved Hide resolved

profclems reviewed Dec 28, 2020

View reviewed changes

commands/issue/create/issue_create.go Outdated Show resolved Hide resolved

maxice8 added 4 commits December 28, 2020 17:09

fix(commands/issue/create): add double quotes around labels

6b102dd

This is required for complex enough labels like `type:build-failure`, if there are no double quotes around it, GitLab will fail to parse it.

fix(commands/issue/create): escape description before using it in Raw…

500d620

…Query It is required, otherwise long descriptions will complex lines like build logs will fail

fix(commands/mr/create): add double quotes around labels

b5c6c4c

This is required for complex enough labels like `type:build-failure`, if there are no double quotes around it, GitLab will fail to parse it.

fix(commands/mr/create): escape description before using it in RawQuery

69d1e62

It is required, otherwise long descriptions will complex lines like build logs will fail

pull-request-size bot added size/S and removed size/XS labels Dec 28, 2020

profclems approved these changes Dec 28, 2020

View reviewed changes

profclems merged commit 173e98c into profclems:trunk Dec 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`issue create` and `mr create` escape #430

`issue create` and `mr create` escape #430

maxice8 commented Dec 28, 2020

maxice8 commented Dec 28, 2020

profclems commented Dec 28, 2020

maxice8 commented Dec 28, 2020

issue create and mr create escape #430

issue create and mr create escape #430

Conversation

maxice8 commented Dec 28, 2020

maxice8 commented Dec 28, 2020

profclems commented Dec 28, 2020

maxice8 commented Dec 28, 2020

`issue create` and `mr create` escape #430

`issue create` and `mr create` escape #430