Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

feat(commands/mr/checkout): accept OWNER:branch format for MRs #529

Merged
merged 1 commit into from
Jan 7, 2021
Merged

feat(commands/mr/checkout): accept OWNER:branch format for MRs #529

merged 1 commit into from
Jan 7, 2021

Conversation

maxice8
Copy link
Collaborator

@maxice8 maxice8 commented Jan 7, 2021

Description

This allows users to use mr checkout <branch> and mr checkout OWNER:branch to checkout by the branch instead of requiring to use the ID

Related Issue

Resolves #528

How Has This Been Tested?

On gitlab.alpinelinux.org instance

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #529 (80ffb73) into trunk (1c17a7d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            trunk     #529   +/-   ##
=======================================
  Coverage   59.19%   59.19%           
=======================================
  Files          85       85           
  Lines        5737     5737           
=======================================
  Hits         3396     3396           
  Misses       2006     2006           
  Partials      335      335           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c17a7d...80ffb73. Read the comment docs.

@profclems profclems added the enhancement New feature or request label Jan 7, 2021
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

Something small to fix up:
The usage info must include branch

Use:   "checkout {<id> | <branch>}",

@maxice8
Copy link
Collaborator Author

maxice8 commented Jan 7, 2021

Done, thanks.

@maxice8 maxice8 dismissed profclems’s stale review January 7, 2021 14:04

Changes applied

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing

commands/mr/checkout/mr_checkout.go Outdated Show resolved Hide resolved
@maxice8 maxice8 requested a review from profclems January 7, 2021 16:06
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear... thanks a lot!

@maxice8 maxice8 merged commit 0c688d5 into profclems:trunk Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can't checkout merge requests by its source branch
2 participants