This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
chore(scripts): make quick installer script POSIX sh compliant #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## trunk #560 +/- ##
==========================================
+ Coverage 61.01% 61.31% +0.29%
==========================================
Files 88 88
Lines 6100 6157 +57
==========================================
+ Hits 3722 3775 +53
- Misses 2027 2029 +2
- Partials 351 353 +2
Continue to review full report at Codecov.
|
maxice8
reviewed
Jan 11, 2021
maxice8
reviewed
Jan 11, 2021
profclems
force-pushed
the
ch-posix-script
branch
from
1b40c17 to
33491e2
Compare
Currently the quick install script isn't POSIX compliant and hence, works only on bash. In order to make it run on all shell types, it must be POSIX sh compliant. All bashisms have been checks and removed/fixed to POSIX sh formats.
profclems
force-pushed
the
ch-posix-script
branch
from
33491e2 to
a2c2534
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the quick install script isn't POSIX sh compliant and hence, works only
on bash.
In order to make it run on all shell types, it must be POSIX sh compliant.
All bashisms have been checks and removed/fixed to POSIX sh formats.