This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Fix unassign #576
Merged
Fix unassign #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that 0 is not a valid username: ```console foo@bar:~$ glab issue update --unassign failed to find user by name : 0 ```
turns out it causes segfaults here because we are dealing with a nil pointer and also if worked it would cause the asssignment to the person that claimed the username '0'.
Codecov Report
@@ Coverage Diff @@
## trunk #576 +/- ##
==========================================
- Coverage 55.07% 55.07% -0.01%
==========================================
Files 103 103
Lines 6912 6913 +1
==========================================
Hits 3807 3807
Misses 2746 2746
- Partials 359 360 +1
Continue to review full report at Codecov.
|
|
I didn't test the |
|
It passed a string called 0 which was not a valid username, it would also segfault on mr update |
profclems
approved these changes
Jan 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make unassign actually work
How Has This Been Tested?
On gitlab.alpinelinux.org and gitlab.com
Types of changes