-
-
Notifications
You must be signed in to change notification settings - Fork 163
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #585 +/- ##
==========================================
- Coverage 54.76% 54.63% -0.13%
==========================================
Files 103 103
Lines 6928 6946 +18
==========================================
+ Hits 3794 3795 +1
- Misses 2777 2791 +14
- Partials 357 360 +3
Continue to review full report at Codecov.
|
var status string | ||
switch s := mr.Pipeline.Status; s { | ||
case "failed": | ||
status = utils.Red(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a change for ci status, that we printed pipeline status yellow, if it's allowed to fail
like here
glab/commands/ci/status/status.go
Lines 84 to 89 in 8f5df7f
case "failed": | |
if job.AllowFailure { | |
status = utils.Yellow(s) | |
} else { | |
status = utils.Red(s) | |
} |
I would actually suggest that we bring out this pipeline status printing out, it's own helper function, so we can centralize it everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right. I will do that
@zemzale do you have any suggestion as to how we can implement the approval status? The Approvals API is only available for starter and bronze users so I'm hesitant to use it. |
I don't have any experience with the approval API or even that part of MRs, since I don't use it. Saddly I am currently not really able to dig deeper into the topic either. So I cant help on this one |
I think the approval status can't be part of v1.14.0 yet |
Description
Related Issue
Resolves #557, #322
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes