This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix repo override -R | --repo
#591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensures repo override supports HOST/GROUP/NAMESPACE/REPO. **Support for GROUP/NAMESPACE/REPO** First, checks if the first part matches the default instance host (i.e. gitlab.com) or the overridden default host (mostly from the GITLAB_HOST env variable). Dots (.) are allowed in group names by GitLab. So we check if if the first part contains a dot. However, it could be that the user is specifying a hostname but we can't be sure of that So we check in the list of authenticated hosts and see if it matches any if not, we assume it is a group name that contains a dot if the first part is not a valid URL, and does not match an authenticated hostname then we assume it is in the format GROUP/NAMESPACE/REPO
Codecov Report
@@ Coverage Diff @@
## trunk #591 +/- ##
=======================================
Coverage 54.63% 54.64%
=======================================
Files 103 103
Lines 6946 6980 +34
=======================================
+ Hits 3795 3814 +19
- Misses 2791 2804 +13
- Partials 360 362 +2
Continue to review full report at Codecov.
|
Only public projects can be found using the project ID
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures repo override supports HOST/GROUP/NAMESPACE/REPO.
Support for GROUP/NAMESPACE/REPO
First, checks if the first part matches the default instance host (i.e. gitlab.com) or the overridden default host (mostly from the GITLAB_HOST env variable).
Dots (.) are allowed in group names by GitLab. So we check if the first part contains a dot.
However, it could be that the user is specifying a hostname but we can't be sure of that. So we check in the list of authenticated hosts and see if it matches any. if not, we assume it is a group name that contains a dot.
if the first part is not a valid URL and does not match an authenticated hostname then we assume it is in the format GROUP/NAMESPACE/REPO
Removes support for project ID
Use PersistentPreRunE instead of PersistentPreRun to ensure errors are printed
Related Issue
Closes #589