This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
entirely remove dependency on tcnksm/go-gitconfig #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcnksm/go-gitconfig was used earlier in glab before we added our own git package. tcnksm/go-gitconfig seems to be no longer maintained since the last update was in somewhere around 2015. This removes dependency on tcnksm/go-gitconfig anbd replaces with our internal git package.
Codecov Report
@@ Coverage Diff @@
## trunk #600 +/- ##
=======================================
Coverage 60.70% 60.70%
=======================================
Files 90 90
Lines 6314 6314
=======================================
Hits 3833 3833
Misses 2120 2120
Partials 361 361 Continue to review full report at Codecov.
|
profclems
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tcnksm/go-gitconfig was used earlier in glab before we added our own git package.
tcnksm/go-gitconfig seems to be no longer maintained since the last update
was in somewhere around 2015.
This removes dependency on tcnksm/go-gitconfig anbd replaces with
our internal git package.