Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Add prompt to git init on repo create. Fixes #569 #601

Merged
merged 3 commits into from
Feb 2, 2021

Conversation

cvhariharan
Copy link
Contributor

@cvhariharan cvhariharan commented Feb 1, 2021

Description
Adds a prompt to run git init if the directory is not initialized before running glab repo create.

Related Issue
Resolves #569

How Has This Been Tested?

  • Created an empty directory without running git init and running glab repo create directly. -> Prompt for git init shown
  • Created an empty directory and ran git init before running glab repo create. -> No prompt shown

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #601 (2d419bb) into trunk (491ad85) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #601      +/-   ##
==========================================
- Coverage   60.70%   60.49%   -0.22%     
==========================================
  Files          90       90              
  Lines        6314     6348      +34     
==========================================
+ Hits         3833     3840       +7     
- Misses       2120     2147      +27     
  Partials      361      361              
Impacted Files Coverage Δ
commands/project/create/project_create.go 0.00% <0.00%> (ø)
internal/config/config_type.go 69.12% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491ad85...2d419bb. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @cvhariharan for your contribution. Sorry I couldn't review much earlier.

I have just one issue that should be fixed before merging this PR

commands/project/create/project_create.go Show resolved Hide resolved
@profclems profclems added the enhancement New feature or request label Feb 2, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 2, 2021
Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cvhariharan for taking this on... LGTM

commands/project/create/project_create.go Show resolved Hide resolved
@profclems profclems merged commit 05db901 into profclems:trunk Feb 2, 2021
@cvhariharan
Copy link
Contributor Author

Thanks @profclems. This is a really cool and useful project. Happy to help 😄.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt to 'git init' on repo create
2 participants