This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 161
allow more than one merge request to be defined for certain mr
commands
#622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
With these changes we can now accept multiple branches if we use MRsFromArgs instead of MRFromArgs (notice the missing `s`).
profclems
reviewed
Feb 22, 2021
Sorry I took long reviewing this PR. It touches crucial parts and I had to make sure everything is in place... |
changes in mrutils.go has caused the error message to appear different than what is expected in the test, so adapt it to the new value
Codecov Report
@@ Coverage Diff @@
## trunk #622 +/- ##
==========================================
+ Coverage 60.49% 60.51% +0.01%
==========================================
Files 90 90
Lines 6354 6357 +3
==========================================
+ Hits 3844 3847 +3
+ Misses 2149 2148 -1
- Partials 361 362 +1
Continue to review full report at Codecov.
|
profclems
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @maxice8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Certain commands from
mr
now support passing multiple merge request via multiple args like:How Has This Been Tested?
Tested by approving multiple merge requests and then revoking them on gitlab.alpinelinux.org
Types of changes