Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

allow more than one merge request to be defined for certain mr commands #622

Merged
merged 11 commits into from
Feb 22, 2021
Merged

allow more than one merge request to be defined for certain mr commands #622

merged 11 commits into from
Feb 22, 2021

Conversation

maxice8
Copy link
Collaborator

@maxice8 maxice8 commented Feb 17, 2021

Description
Certain commands from mr now support passing multiple merge request via multiple args like:

foo@bar:~$ glab mr close 1 branch-that-maps-to-mr-2 3
[closes MRs !1 !2 !3]

How Has This Been Tested?

Tested by approving multiple merge requests and then revoking them on gitlab.alpinelinux.org

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (Related to CI or Packaging to platforms)

@profclems
Copy link
Owner

Sorry I took long reviewing this PR. It touches crucial parts and I had to make sure everything is in place...
Everything looks good but the test should be fixed

changes in mrutils.go has caused the error message to appear different
than what is expected in the test, so adapt it to the new value
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #622 (a5314ba) into trunk (0be545a) will increase coverage by 0.01%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##            trunk     #622      +/-   ##
==========================================
+ Coverage   60.49%   60.51%   +0.01%     
==========================================
  Files          90       90              
  Lines        6354     6357       +3     
==========================================
+ Hits         3844     3847       +3     
+ Misses       2149     2148       -1     
- Partials      361      362       +1     
Impacted Files Coverage Δ
commands/mr/mrutils/mrutils.go 79.50% <0.00%> (+4.89%) ⬆️
commands/mr/subscribe/mr_subscribe.go 81.25% <66.66%> (ø)
commands/mr/unsubscribe/mr_unsubscribe.go 81.25% <66.66%> (ø)
commands/mr/delete/mr_delete.go 84.61% <100.00%> (+0.61%) ⬆️
commands/issue/create/issue_create.go 32.12% <0.00%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0be545a...a5314ba. Read the comment docs.

Copy link
Owner

@profclems profclems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @maxice8

@maxice8 maxice8 merged commit c143c98 into profclems:trunk Feb 22, 2021
@profclems profclems added cmd: mr Issue is related to merge request management enhancement New feature or request labels Feb 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cmd: mr Issue is related to merge request management enhancement New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants