This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
fix(mr): Use default branch on mr create #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When branch is pushed to remote, the target branch came out to be the remote traking branch, which would become target == source. That can't work so this needs to be removed. Resolves !619
profclems
changed the title
|
@profclems Any idea why the test is failing? Also, any idea how I can run them normally locally since I get output like this Error: "\nCreating merge request for \x1b[0;36mfeat-new-mr\x1b[0m into \x1b[0;36mmaster\x1b[0m in OWNER/REPO\n\n" does not contain "\nCreating merge request for feat-new-mr into master in OWNER/REPO\n\n"which does seem to be because of some escape codes, for the color output |
profclems
added
cmd: mr
Codecov Report
@@ Coverage Diff @@
## trunk #630 +/- ##
==========================================
+ Coverage 60.51% 60.54% +0.03%
==========================================
Files 90 90
Lines 6357 6352 -5
==========================================
- Hits 3847 3846 -1
+ Misses 2148 2145 -3
+ Partials 362 361 -1
Continue to review full report at Codecov.
|
profclems
approved these changes
Feb 28, 2021
|
I will create a new release today since this resolves a problem that might possibly hinder workflow |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When branch is pushed to remote, the target branch came out to be the
remote traking branch, which would become target == source. That can't
work so this needs to be removed.
Related Issue
Resolves #619
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes